-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Transfer demos to TS #2825
Navigation: Transfer demos to TS #2825
Conversation
</p> | ||
<p> | ||
Website:{' '} | ||
<a |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
</p> | ||
<p> | ||
Website:{' '} | ||
<a |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
@@ -149,7 +149,7 @@ function App() { | |||
const renderTextAlignMenu = React.useCallback( | |||
() => ( | |||
<ButtonGroup | |||
displayExpr="text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this line
Our docs and typescript say that there is no displayExpr in ButtonGroup
? itemsDriveC | ||
: itemsDriveD; | ||
|
||
moveNode(fromNode, toNode, fromItems, toItems, e.dropInsideItem); | ||
|
||
if (getStateFieldName(e.fromData) === 'driveC') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it was a bug in demo, and typescript helped to fix it
@@ -18,7 +18,7 @@ const calculateToIndex = (e) => { | |||
: e.toIndex + 1; | |||
}; | |||
|
|||
const findNode = (treeView, index) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In places like this its strange for me, that i cant easily get instance type from component. If we use ref.current.instance, the type is correct, but i can't use TreeViewTypes.instance or smth alike
No description provided.