Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Transfer demos to TS #2825

Merged
merged 32 commits into from
Nov 13, 2023

Conversation

ivanblinov2k17
Copy link
Contributor

No description provided.

@ivanblinov2k17 ivanblinov2k17 self-assigned this Sep 7, 2023
</p>
<p>
Website:{' '}
<a

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
</p>
<p>
Website:{' '}
<a

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@ivanblinov2k17 ivanblinov2k17 marked this pull request as ready for review September 14, 2023 15:09
@@ -149,7 +149,7 @@ function App() {
const renderTextAlignMenu = React.useCallback(
() => (
<ButtonGroup
displayExpr="text"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this line
Our docs and typescript say that there is no displayExpr in ButtonGroup

? itemsDriveC
: itemsDriveD;

moveNode(fromNode, toNode, fromItems, toItems, e.dropInsideItem);

if (getStateFieldName(e.fromData) === 'driveC') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was a bug in demo, and typescript helped to fix it

@@ -18,7 +18,7 @@ const calculateToIndex = (e) => {
: e.toIndex + 1;
};

const findNode = (treeView, index) => {
Copy link
Contributor Author

@ivanblinov2k17 ivanblinov2k17 Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In places like this its strange for me, that i cant easily get instance type from component. If we use ref.current.instance, the type is correct, but i can't use TreeViewTypes.instance or smth alike

@ivanblinov2k17 ivanblinov2k17 requested review from dxvladislavvolkov and a team September 15, 2023 07:53
@ivanblinov2k17 ivanblinov2k17 merged commit cf0c05f into DevExpress:23_2 Nov 13, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants